Add Craig Perkins as OpenSearch Maintainer#17046
Merged
dbwiddis merged 1 commit intoopensearch-project:mainfrom Jan 17, 2025
Merged
Add Craig Perkins as OpenSearch Maintainer#17046dbwiddis merged 1 commit intoopensearch-project:mainfrom
dbwiddis merged 1 commit intoopensearch-project:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the process at https://github.com/opensearch-project/.github/blob/main/RESPONSIBILITIES.md#becoming-a-maintainer, I have nominated and other maintainers have agreed to add Craig Perkins (@cwperks) as a co-Maintainer of the OpenSearch repository. Craig has kindly accepted the invitation.
Craig has been a long-time and consistent contributor to OpenSearch since 2022. Out of a raw total of 157 PRs I tried to filter out backports, merges, version bumps, and minor changes and still have almost 50 substantive contributions.
Most recently, he fixed a longstanding pet peeve of mine: his very first PR to the project was a CVE-fixing version bump (#3772) that dependabot missed. He followed through on that in exploring and committing a switch to a version catalog that not only aids dependabot but can help plugins and other dependencies keep in sync without jar hell.
buildSrc/version.propertiesto Gradle version catalog (gradle/libs.versions.toml) to enable dependabot to perform automated upgrades on common libs #16284 and Make entries for dependencies from server/build.gradle to gradle version catalog #16707Some time back he started with a bug fix for regex recursion, took some feedback that I thought about in a comment (but failed to implement myself) and implemented an elegant non-recursive much more performant shortcut:
Some other highlights:
Multiple security and identity-related PRs. More significant ones:
Added code to prevent accidentally bypassing RestHandler.Wrapper:
Bugfixes:
Unglamorous but helpful and necessary glue work:
index.mapper.dynamicin AutoCreateIndex #13067The whole identity experimental feature
He's committed upstream to Lucene:
He's created 19 issues including bugs and feature requests, of which 10 have been actioned
He has reviewed 72 PRs (that he didn't author):
I believe Craig has already been participating as much or more than many maintainers (myself included) and would be a valuable addition to the maintainer team.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.